Before merging a Pull-Request, make sure that it builds when merged. The Hawkular repositories have been set up to
run continuous integration (CI) on Pull-Requests.
In above detail view of a pull-request, you can see that the first commit (e44f90a) failed CI by the red cross next
to the commit id. The commit after it then passed as you can see by the green check mark. Those markers are
shown for commits on the Conversation and Commits tab in the GitHub UI.
Only merge Pull-Requests that have successfully passed CI
The Files Changed tab allow to review the commits as difference to the reference branch (usually master). It is
possible to comment on individual lines by hovering the mouse cursor on the line separator between lne numbers and
code until a little white plus on blue appears. Click on it and add your comment.
If you have opened a comment, allow the submitter (and others) to reply and potentially update the code.
Do not merge your own PRs, but have someone else look over them
Criteria for merging
As a code-reviewer, try to apply these criteria before merging:
After everything looks good, press the big green merge button :-)